[EO] Multiple Item Drops and Percentile Chances

[Ertzel]

Ya, its not working that way for me… Its only letting me set them as 0 or 1 and if I do anything thats like 2.0 or something it changes it to 0.... So its either an item drops 100% of the time or 0% of the time....

the code for entering shit into txtChange is this...
```
Private Sub txtChance_Change()
    On Error GoTo chanceErr
    Dim DropIndex As Long

    If Not IsNumeric(txtChance.text) And Not Right$(txtChance.text, 1) = "%" And Not InStr(1, txtChance.text, "/") > 0 And Not InStr(1, txtChance.text, ".") Then
        txtChance.text = "0"
        Npc(EditorIndex).DropChance(DropIndex) = 0
        Exit Sub
    End If

    If Right$(txtChance.text, 1) = "%" Then
        txtChance.text = left(txtChance.text, Len(txtChance.text) - 1) / 100
    ElseIf InStr(1, txtChance.text, "/") > 0 Then
        Dim i() As String
        i = Split(txtChance.text, "/")
        txtChance.text = Int(i(0) / i(1) * 1000) / 1000
    End If

    If txtChance.text > 1 Or txtChance.text < 0 Then
        Err.Description = "Value must be between 0 and 1!"
        GoTo chanceErr
    End If

    Npc(EditorIndex).DropChance(DropIndex) = txtChance.text
    Exit Sub

chanceErr:
    MsgBox "Invalid entry for chance! " & Err.Description
    txtChance.text = "0"
    Npc(EditorIndex).DropChance(DropIndex) = 0
End Sub
```
Thats what it is in the attached frm_Editor_NPC and that only lets it be 0 or 1…

[viciousdead]

@Ertzel:

> Ya, its not working that way for me… Its only letting me set them as 0 or 1 and if I do anything thats like 2.0 or something it changes it to 0.... So its either an item drops 100% of the time or 0% of the time....
>
> the code for entering shit into txtChange is this...
> ```
> Private Sub txtChance_Change()
>     On Error GoTo chanceErr
>     Dim DropIndex As Long
>    
>     If Not IsNumeric(txtChance.text) And Not Right$(txtChance.text, 1) = "%" And Not InStr(1, txtChance.text, "/") > 0 And Not InStr(1, txtChance.text, ".") Then
>         txtChance.text = "0"
>         Npc(EditorIndex).DropChance(DropIndex) = 0
>         Exit Sub
>     End If
>    
>     If Right$(txtChance.text, 1) = "%" Then
>         txtChance.text = left(txtChance.text, Len(txtChance.text) - 1) / 100
>     ElseIf InStr(1, txtChance.text, "/") > 0 Then
>         Dim I() As String
>         I = Split(txtChance.text, "/")
>         txtChance.text = Int(I(0) / I(1) * 1000) / 1000
>     End If
>    
>     If txtChance.text > 1 Or txtChance.text < 0 Then
>         Err.Description = "Value must be between 0 and 1!"
>         GoTo chanceErr
>     End If
>    
>     Npc(EditorIndex).DropChance(DropIndex) = txtChance.text
>     Exit Sub
>    
> chanceErr:
>     MsgBox "Invalid entry for chance! " & Err.Description
>     txtChance.text = "0"
>     Npc(EditorIndex).DropChance(DropIndex) = 0
> End Sub
> ```
> Thats what it is in the attached frm_Editor_NPC and that only lets it be 0 or 1…

No, you don't understand, you cannot go above or bellow 0 & 1 everything between 0 & 1 you can pick, Example: 0.001, 0.00002499429, 0.12894718742047990127490, 0.5 = 1/2…

[Ertzel]

Thats the problem… if something is set to like 1/2 (so it goes to 0.5) it wont save as 0.5, it will only save as either 0 or 1.....

[viciousdead]

@Ertzel:

> Thats the problem… if something is set to like 1/2 (so it goes to 0.5) it wont save as 0.5, it will only save as either 0 or 1.....

Oh, then redo the tut, that's what I have had to do in the past, it shouldn't take you long.

[Ertzel]

I have, it keeps giving me the same prob….

[Bafoon]

I got the error, cant assign to array, my friend had the same problem. on line,
```
Npc(EditorIndex).DropItem = scrlNum.Value
```and .DropItem was highlighted.

[iSKweek]

Would it be possible for you to update this for the latest version of EO please? I have tried sorting out the differences and problems but I am not quite good enough at this just yet :P

[dream1204]

Same as above….. I am using EO1.50\. And I can't find "'drop the goods if......" in GameLogic and ModPlayer files...... plz help me with this. Teach me how to do multi-item drop in  EO 1.50 :)

[iSKweek]

Re-do the tutorial. I found out it was just a mistake I made personally. This tutorial works fine.

[dream1204]

redo this 4 times. I make it works! Great! Thanks a lot.
However, I got a little problem that in my chance value in editor, there will be a huge number in it… Everytime I want to change the chance, I have to delete it, then type in.
Just like pic in my attachment....

Thank you very much!

[JessicaLecroix]

I don't mean to be a bother, but is there a way to get this to work in EO 1.5? The way NPC drops are handled seems to have changed completely, as the line
```
' Drop the goods if they get it
```is completely missing, as is the 1.0/1.1 code for how NPC drops are handled.

[iSKweek]

Works perfectly fine in 1.5\. That line is still in the source. Pretty sure it is just in modCombat.

Ctrl + F is your friend.

[JessicaLecroix]

Er, I think I might be a bit of a moron then… This is the code I'm trying to replace, right?
```
        ' Drop the goods if they get it
        n = Int(Rnd * Npc(vNpcNum).DropChance) + 1
        If n = 1 Then
            Call SpawnItem(Npc(vNpcNum).DropItem, Npc(vNpcNum).DropItemValue, MapNum, MapNpc(MapNum).Npc(Victim).x, MapNpc(MapNum).Npc(Victim).y)
        End If
```If so, it isn't present anywhere in any server module. If not… Well, then I'm probably just too thick to get this to work.

[iSKweek]

Just search through the playerattacknpc sub for it. It is there. If it isn't then redownload EO.

[Joyce]

It's still here, things just changed locations and some minor tweaks to the remarks.. But all the code is still there if you know where to look. :) And you can't blatantly copy/paste shit anymore, as the editors have changed as well.. Which is good :P

EDIT : This actually requires more work to get it functional with the new Beta then I had anticipated.. It's worth the effort though. :)

[JessicaLecroix]

Er, I don't think there's a way to re-download EO 1.5 now that the new beta's out. It's definitely not there. I must have gotten rid of it by accident, and I don't know enough yet to get this working in 2.0, but thank you for your help.
–-------
EDIT: Nevermind, found a way to get the older version. Thanks again for your help.

[EclipseCommunity]

For those trying to find **' Drop the goods if they get it**, trying finding **'Drop the goods if they get it** instead. ;)

[sigridundset]

Sorry, I'm new at Eclipse, but try as I might, I cannot find the line : ''Drop the goods if they get it'' in the modGameLogic section or the modPlayer section. I don't know if this makes a difference, but I'm using the v.2 Beta. Please Help

[Robin]

This was made a year ago for an older version of the engine. The combat functions have since been moved to modCombat.

[erkro1]

For the people that having trouble with 'Drop the goods if they get it part, try this code (works for me) :
```
'Drop the goods if they get it
                For y = 1 To MAX_NPC_DROPS
                    If NPC(npcNum).DropItem(y) = 0 Then Exit For
                    If Rnd <= NPC(npcNum).DropChance(y) Then
                        Call SpawnItem(NPC(npcNum).DropItem(y), NPC(npcNum).DropItemValue(y), mapNum, MapNpc(mapNum).NPC(mapNpcNum).x, MapNpc(mapNum).NPC(mapNpcNum).y)
                    End If
                Next
```

[Rithy58]

So I'm guessing this doesn't work with EO 2.0 without some modification?

Sincerely,
Rithy

[erkro1]

Yes

[NexCarcer]

I clicked on start with full compile, but I got an error and it said:

Compile Error: Method of data member not found

And pointed to this line, highlighting the ".sound" part:

```
soundName = Trim$(Npc(entityNum).Sound)
```
Any fixes?

[Yxxe]

@NexCarcer:

> I clicked on start with full compile, but I got an error and it said:
>
> Compile Error: Method of data member not found
>
> And pointed to this line, highlighting the ".sound" part:
>
> ```
> soundName = Trim$(Npc(entityNum).Sound)
> ```
> Any fixes?

Load up your server-side code and then go to modTypes. Does your NpcRec look like this?

```
Private Type NpcRec
    Name As String * NAME_LENGTH
    AttackSay As String * 100
    Sound As String * NAME_LENGTH

    Sprite As Long
    SpawnSecs As Long
    Behaviour As Byte
    Range As Byte
    DropChance(1 To 10) As Double
    DropItem(1 To 10) As Long
    DropItemValue(1 To 10) As Long
    Stat(1 To Stats.Stat_Count - 1) As Byte
    HP As Long
    Exp As Long
    Animation As Long
    Damage As Long
    Level As Long
End Type
```
You may have the "Sound As String *NAME_LENGTH" missing.

[NexCarcer]

Forget it, I'll wait for the next release. I already have a system in place. I have no idea what I'm doing, and I don't think it'll work unless I have someone go on teamviewer with me to fix it.