Optional data sending

[Notsu]

CLIENT:

```

Sub SendSomething(ByVal LongValue As Long, ByVal StringValue As String)

Dim Buffer As clsBuffer

Set Buffer = New clsBuffer

Buffer.WriteLong CGuildCommand

Buffer.WriteLong LongValue

If StringValue <> vbNullString Then

Buffer.WriteString StringValue

End If

SendData Buffer.ToArray()

Set Buffer = Nothing

End Sub

```

SERVER:

```

Sub HandleSomething(ByVal index As Long, ByRef Data() As Byte, ByVal StartAddr As Long, ByVal ExtraVar As Long)

Dim buffer As clsBuffer

Dim LongValue As Long, StringValue As String

Set buffer = New clsBuffer

buffer.WriteBytes Data()

LongValue = buffer.ReadLong

StringValue = buffer.ReadString

Set buffer = Nothing

End Sub

```

Is it worth? Is it optimal and done in proper way? I'm saying about lines where is check: if StringValue is not empty then send it.

But the server will try to read string if it's not sent in client code.

I hope you'll understand. 

Thanks for reply.

[Stein]

And how are you going to handle this on the receiving end, just assume everything is sent or guess and hope it doesn't crash?

[Notsu]

That's why I'm asking, I tested it before post and it works without crash.

[JohnPony]

That's because you only tested it when you're sending a string.

Test it without a string and it will crash, because you're trying to read beyond the byte array's max capacity.

[Notsu]

No, I tested it with and without stringvalue.(I entered vbNullString as StringValue in that case)

But if it should crash I'll delete that check.