I need help with my start of a pet-script…

[Sealbreaker]

yeah…the name says everything... pls dont say things like: dont try it man or somethin like this <.<

so, here is my script and i dont know why it doesnt work....

```
    Case "/summonpet"
        DIM playerx
        DIM playery
        DIM playermap
        DIM npconmap+1
        DIM npconmap
        DIM playertarget
        DIM playermp
        DIM petnumber
        DIM petsnumber+1
        DIM petsnumber
        DIM petdef
        DIM petstr
        DIM petmaxhp
        DIM pethp
        DIM petmapnumber

        playerx = GetPlayerX(index)
        playery = GetPlayerY(index)
        playermap = GetPlayerMap(index)
        npconmap+1 = GetMapNpcNumber(GetPlayerMap(index), index) + 1)
        npconmap = GetMapNpcNumber(GetPlayerMap(index), index)
        playertarget = GetPlayerTargetNpc(index)
        playermp = GetPlayerMP(index) - 20)
        petnumber = GetVar(GetPlayerName(index) & ".ini", "PET", "petnumber")
        petsnumber+1 = GetVar("Data.ini", "PETS", "petsnumber") + 1)
        petsnumber = GetVar("Data.ini", "PETS", "petsnumber")
        petdef = GetNpcDefense(petnumber)
        petstr = GetNpcStrength(petnumber)
        petmaxhp = GetNpcMaxHP(index)
        pethp = GetNpcHP(petnumber)
        petmapnumber = GetVar(GetPlayerName(index) & ".ini", "PET", "petmapnumber")

                    If GetVar(GetPlayerName(index) & ".ini", "PET", "activatedbefore", 0) Then
                    If GetVar(GetPlayerName(index) & ".ini", "PET", "petactivated", 0) Then
                                  Call PutVar(GetPlayerName(index) & ".ini", "PET", "petnumber", petsnumber+1)
                                  Call PutVar("Data.ini", "PETS", "petsnumbers", petsnumber+1)
                                  Call PutVar(GetPlayerName(index) & ".ini", "PET", "petdef", 40)
                                  Call PutVar(GetPlayerName(index) & ".ini", "PET", "petstr", 35)
                                  Call PutVar(GetPlayerName(index) & ".ini", "PET", "petexp", 10)
                                  Call ScriptSpawnNpc(npconmap+1, playermap, playerx, playery, petnumber)
                                  Call PutVar(GetPlayerName(index) & ".ini", "PET", "petmapnumber", npconmap+1)
                                  Call SetPlayerMP(index, playermp) 
                                  Call PlayerMsg(index, "You summoned your pet", GREEN)
                                  Call PutVar(GetPlayerName(index) & ".ini", "PET", "petactivated", 1)
                                  Call SendNPC(playermap, npconmap)
                    ElseIf GetVar(GetPlayerName(index) & ".ini", "PET", "activatedbefore", 1) Then
                    If GetVar(GetPlayerName(index) & ".ini", "PET", "petactivated", 0) Then
                                  Call ScriptSpawnNpc(npconmap+1, playermap, playerx, playery, petnumber)
                                  Call PutVar(GetPlayerName(index) & ".ini", "PET", "petactivated", 1)
                                  Call PlayerMsg(index, "You summoned your pet", GREEN)
                                  Call SetPlayerMP(index, playermp)
                                  Call SendNPC(playermap, npconmap) 
        End If
Exit Sub
```
here is the .ini:

```
[PET]
activatedbefore=0
petactivated=0
petattacking=0
petdead=0
petnumber=0
petmapnumber=0
petstr=0
petdef=0
pethp=0
petexp=0

```
i created a .ini file by myself for testing the script….called it sealbreaker and called my char sealbreaker.... but thecommand doesnt do anything... help pls.. =P

[VitinhooxD]

the ifs are really bugged.Theres 3 ifs and you only put 1 end if =X
You can try this way
```
      Case "/summonpet"
        DIM playerx
        DIM playery
        DIM playermap
        DIM npconmap+1
        DIM npconmap
        DIM playertarget
        DIM playermp
        DIM petnumber
        DIM petsnumber+1
        DIM petsnumber
        DIM petdef
        DIM petstr
        DIM petmaxhp
        DIM pethp
        DIM petmapnumber

        playerx = GetPlayerX(index)
        playery = GetPlayerY(index)
        playermap = GetPlayerMap(index)
        npconmap+1 = GetMapNpcNumber(GetPlayerMap(index), index) + 1)
        npconmap = GetMapNpcNumber(GetPlayerMap(index), index)
        playertarget = GetPlayerTargetNpc(index)
        playermp = GetPlayerMP(index) - 20)
        petnumber = GetVar(GetPlayerName(index) & ".ini", "PET", "petnumber")
        petsnumber+1 = GetVar("Data.ini", "PETS", "petsnumber") + 1)
        petsnumber = GetVar("Data.ini", "PETS", "petsnumber")
        petdef = GetNpcDefense(petnumber)
        petstr = GetNpcStrength(petnumber)
        petmaxhp = GetNpcMaxHP(index)
        pethp = GetNpcHP(petnumber)
        petmapnumber = GetVar(GetPlayerName(index) & ".ini", "PET", "petmapnumber")

                    If GetVar(GetPlayerName(index) & ".ini", "PET", "activatedbefore", 0) Then
                      If GetVar(GetPlayerName(index) & ".ini", "PET", "petactivated", 0) Then
                                  Call PutVar(GetPlayerName(index) & ".ini", "PET", "petnumber", petsnumber+1)
                                  Call PutVar("Data.ini", "PETS", "petsnumbers", petsnumber+1)
                                  Call PutVar(GetPlayerName(index) & ".ini", "PET", "petdef", 40)
                                  Call PutVar(GetPlayerName(index) & ".ini", "PET", "petstr", 35)
                                  Call PutVar(GetPlayerName(index) & ".ini", "PET", "petexp", 10)
                                  Call ScriptSpawnNpc(npconmap+1, playermap, playerx, playery, petnumber)
                                  Call PutVar(GetPlayerName(index) & ".ini", "PET", "petmapnumber", npconmap+1)
                                  Call SetPlayerMP(index, playermp)
                                  Call PlayerMsg(index, "You summoned your pet", GREEN)
                                  Call PutVar(GetPlayerName(index) & ".ini", "PET", "petactivated", 1)
                      End If          Call SendNPC(playermap, npconmap)
                    ElseIf GetVar(GetPlayerName(index) & ".ini", "PET", "activatedbefore", 1) Then
                        If GetVar(GetPlayerName(index) & ".ini", "PET", "petactivated", 0) Then
                                  Call ScriptSpawnNpc(npconmap+1, playermap, playerx, playery, petnumber)
                                  Call PutVar(GetPlayerName(index) & ".ini", "PET", "petactivated", 1)
                                  Call PlayerMsg(index, "You summoned your pet", GREEN)
                                  Call SetPlayerMP(index, playermp)
                                  Call SendNPC(playermap, npconmap)
                    End If
                        End If
Exit Sub

```

[kris_hole]

i count 3 if statements and only 1 end if…

[Sealbreaker]

i'm such an idiot <.<
thank you…. is that all?
*testsnow*

[VitinhooxD]

Dont know.But if need help in something just call me :D

[Sealbreaker]

does not work vitinhoo….
isnt the Call SendNpc right to the End If wrong? shouldn't it be before the end if?
anyway, this isnt working 2

[VitinhooxD]

You dont need the Call SendNpc

[Sealbreaker]

ok… but that cant be the reason why it's not working.... =/

[VitinhooxD]

Activate ScriptError in data.ini and tell me the error

[Sealbreaker]

when starting the server it now says:

TYPE: 'select' erwartet
LINE: 5
COLUMN: 4
CODE:
End If

o.0

[Sealbreaker]

then it says:

TYPE: anweisungsende erwartet ( i'm german btw ;D )
LINE: 72
COLUMN: 12
CODE:
DIM npconmap+1

when i type: /summonpet

it says:

TYPE: typen unverträglich ( i think it means types dont match or somethin ) 'Commands'
LINE: 1
COLUMN: 0
CODE: ( there is no code… )

EDIT:sorry expected you saying i have to write every error i get before i post..so its doublepost - sorry

[VitinhooxD]

try removing all the + for the Dims
eg
Dim lol+1
should be
Dim lol1

[Sealbreaker]

give me a minute…. editing this post then ;D

[Godlord]

Too many useless variables, no comparisons where there should be, random + 1's, etc.

Regards,
  Godlord.

[Sealbreaker]

i want to have the vars for later on…like to have the options....
anyways, i deleted any + that wasnt needed.... only error i get is ( at starting) :

LINE: 87
COLUMN: 59
CODE:
npconmap1 = GetMapNpcNumber(GetPlayerMap(index), index) + 1)

this is the code I'm using atm:

```
      Case "/summonpet"
        DIM playerx
        DIM playery
        DIM playermap
        DIM npconmap1
        DIM npconmap
        DIM playertarget
        DIM playermp
        DIM petnumber
        DIM petsnumber1
        DIM petsnumber
        DIM petdef
        DIM petstr
        DIM petmaxhp
        DIM pethp
        DIM petmapnumber

        playerx = GetPlayerX(index)
        playery = GetPlayerY(index)
        playermap = GetPlayerMap(index)
        npconmap1 = GetMapNpcNumber(GetPlayerMap(index), index) + 1)
        npconmap = GetMapNpcNumber(GetPlayerMap(index), index)
        playertarget = GetPlayerTargetNpc(index)
        playermp = GetPlayerMP(index) - 20)
        petnumber = GetVar(GetPlayerName(index) & ".ini", "PET", "petnumber")
        petsnumber1 = GetVar("Data.ini", "PETS", "petsnumber") + 1)
        petsnumber = GetVar("Data.ini", "PETS", "petsnumber")
        petdef = GetNpcDefense(petnumber)
        petstr = GetNpcStrength(petnumber)
        petmaxhp = GetNpcMaxHP(index)
        pethp = GetNpcHP(petnumber)
        petmapnumber = GetVar(GetPlayerName(index) & ".ini", "PET", "petmapnumber")

                    If GetVar(GetPlayerName(index) & ".ini", "PET", "activatedbefore", 0) Then
                      If GetVar(GetPlayerName(index) & ".ini", "PET", "petactivated", 0) Then
                                  Call PutVar(GetPlayerName(index) & ".ini", "PET", "petnumber", petsnumber1)
                                  Call PutVar("Data.ini", "PETS", "petsnumbers", petsnumber1)
                                  Call PutVar(GetPlayerName(index) & ".ini", "PET", "petdef", 40)
                                  Call PutVar(GetPlayerName(index) & ".ini", "PET", "petstr", 35)
                                  Call PutVar(GetPlayerName(index) & ".ini", "PET", "petexp", 10)
                                  Call ScriptSpawnNpc(npconmap1, playermap, playerx, playery, petnumber)
                                  Call PutVar(GetPlayerName(index) & ".ini", "PET", "petmapnumber", npconmap+1)
                                  Call SetPlayerMP(index, playermp)
                                  Call PlayerMsg(index, "You summoned your pet", GREEN)
                                  Call PutVar(GetPlayerName(index) & ".ini", "PET", "petactivated", 1)
                    End If
                    ElseIf GetVar(GetPlayerName(index) & ".ini", "PET", "activatedbefore", 1) Then
                        If GetVar(GetPlayerName(index) & ".ini", "PET", "petactivated", 0) Then
                                  Call ScriptSpawnNpc(npconmap1, playermap, playerx, playery, petnumber)
                                  Call PutVar(GetPlayerName(index) & ".ini", "PET", "petactivated", 1)
                                  Call PlayerMsg(index, "You summoned your pet", GREEN)
                                  Call SetPlayerMP(index, playermp)
                    End If
                        End If
Exit Sub
```

[kris_hole]

npconmap1 = GetMapNpcNumber(GetPlayerMap(index), index) + 1)

to

npconmap1 = (GetMapNpcNumber(GetPlayerMap(index), index) + 1)

or if that doesnt work put it as

npconmap1 = Val(GetMapNpcNumber(GetPlayerMap(index), index) + 1)

[Sealbreaker]

now it says ( while activating)

TYPE: type dismatch ( typen unverträglich at my pc ) '[string: ""]'
LINE:92
COLUMN: 0
CODE:

[VitinhooxD]

Int() all the vars all are numbers

[Sealbreaker]

so…. like:

lol = Int(GetVar(blablablablabla) + 1)

?

[VitinhooxD]

Yeah

[Godlord]

@VitinhooxD:

> Yeah

No.

It should be:
```
Int(GetVar(...)) + 1
```
and:
```
PutVar(..., ..., ..., CStr(...))
```
If using anything other than strings.

Regards,
  Godlord.

[Sealbreaker]

gives me the same error… =/

code:

```
      Case "/summonpet"
        DIM playerx
        DIM playery
        DIM playermap
        DIM npconmap1
        DIM npconmap
        DIM playertarget
        DIM playermp
        DIM petnumber
        DIM petsnumber1
        DIM petsnumber
        DIM petdef
        DIM petstr
        DIM petmaxhp
        DIM pethp
        DIM petmapnumber

        playerx = GetPlayerX(index)
        playery = GetPlayerY(index)
        playermap = GetPlayerMap(index)
        npconmap1 = Int(GetMapNpcNumber(GetPlayerMap(index), index) + 1)
        npconmap = GetMapNpcNumber(GetPlayerMap(index), index)
        playertarget = GetPlayerTargetNpc(index)
        playermp = Int(GetPlayerMP(index) - 20)
        petnumber = GetVar(GetPlayerName(index) & ".ini", "PET", "petnumber")
        petsnumber1 = Int(GetVar("Data.ini", "PETS", "petsnumber") + 1)
        petsnumber = GetVar("Data.ini", "PETS", "petsnumber")
        petdef = GetNpcDefense(petnumber)
        petstr = GetNpcStrength(petnumber)
        petmaxhp = GetNpcMaxHP(index)
        pethp = GetNpcHP(petnumber)
        petmapnumber = GetVar(GetPlayerName(index) & ".ini", "PET", "petmapnumber")

                    If GetVar(GetPlayerName(index) & ".ini", "PET", "activatedbefore", 0) Then
                      If GetVar(GetPlayerName(index) & ".ini", "PET", "petactivated", 0) Then
                                  Call PutVar(GetPlayerName(index) & ".ini", "PET", "petnumber", petsnumber1)
                                  Call PutVar("Data.ini", "PETS", "petsnumbers", petsnumber1)
                                  Call PutVar(GetPlayerName(index) & ".ini", "PET", "petdef", 40)
                                  Call PutVar(GetPlayerName(index) & ".ini", "PET", "petstr", 35)
                                  Call PutVar(GetPlayerName(index) & ".ini", "PET", "petexp", 10)
                                  Call ScriptSpawnNpc(npconmap1, playermap, playerx, playery, petnumber)
                                  Call PutVar(GetPlayerName(index) & ".ini", "PET", "petmapnumber", npconmap+1)
                                  Call SetPlayerMP(index, playermp)
                                  Call PlayerMsg(index, "You summoned your pet", GREEN)
                                  Call PutVar(GetPlayerName(index) & ".ini", "PET", "petactivated", 1)
                    End If
                    ElseIf GetVar(GetPlayerName(index) & ".ini", "PET", "activatedbefore", 1) Then
                        If GetVar(GetPlayerName(index) & ".ini", "PET", "petactivated", 0) Then
                                  Call ScriptSpawnNpc(npconmap1, playermap, playerx, playery, petnumber)
                                  Call PutVar(GetPlayerName(index) & ".ini", "PET", "petactivated", 1)
                                  Call PlayerMsg(index, "You summoned your pet", GREEN)
                                  Call SetPlayerMP(index, playermp)
                    End If
                        End If
Exit Sub
```

[Godlord]

@Godlord:

> No.
>
> It should be:
> ```
> Int(GetVar(...)) + 1
> ```
> and:
> ```
> PutVar(..., ..., ..., CStr(...))
> ```
> If using anything other than strings.
>
> Regards,
>   Godlord.

Regards,
  Godlord.

[Sealbreaker]

```
      Case "/summonpet"
        DIM playerx
        DIM playery
        DIM playermap
        DIM npconmap1
        DIM npconmap
        DIM playertarget
        DIM playermp
        DIM petnumber
        DIM petsnumber1
        DIM petsnumber
        DIM petdef
        DIM petstr
        DIM petmaxhp
        DIM pethp
        DIM petmapnumber

        playerx = GetPlayerX(index)
        playery = GetPlayerY(index)
        playermap = GetPlayerMap(index)
        npconmap1 = Int(GetMapNpcNumber(GetPlayerMap(index), index)) + 1
        npconmap = GetMapNpcNumber(GetPlayerMap(index), index)
        playertarget = GetPlayerTargetNpc(index)
        playermp = Int(GetPlayerMP(index) - 20)
        petnumber = GetVar(GetPlayerName(index) & ".ini", "PET", "petnumber")
        petsnumber1 = Int(GetVar("Data.ini", "PETS", "petsnumber")) + 1
        petsnumber = GetVar("Data.ini", "PETS", "petsnumber")
        petdef = GetNpcDefense(petnumber)
        petstr = GetNpcStrength(petnumber)
        petmaxhp = GetNpcMaxHP(index)
        pethp = GetNpcHP(petnumber)
        petmapnumber = GetVar(GetPlayerName(index) & ".ini", "PET", "petmapnumber")

                    If GetVar(GetPlayerName(index) & ".ini", "PET", "activatedbefore", 0) Then
                      If GetVar(GetPlayerName(index) & ".ini", "PET", "petactivated", 0) Then
                                  Call PutVar(GetPlayerName(index) & ".ini", "PET", "petnumber", petsnumber1)
                                  Call PutVar("Data.ini", "PETS", "petsnumbers", petsnumber1)
                                  Call PutVar(GetPlayerName(index) & ".ini", "PET", "petdef", 40)
                                  Call PutVar(GetPlayerName(index) & ".ini", "PET", "petstr", 35)
                                  Call PutVar(GetPlayerName(index) & ".ini", "PET", "petexp", 10)
                                  Call ScriptSpawnNpc(npconmap1, playermap, playerx, playery, petnumber)
                                  Call PutVar(GetPlayerName(index) & ".ini", "PET", "petmapnumber", npconmap+1)
                                  Call SetPlayerMP(index, playermp)
                                  Call PlayerMsg(index, "You summoned your pet", GREEN)
                                  Call PutVar(GetPlayerName(index) & ".ini", "PET", "petactivated", 1)
                    End If
                    ElseIf GetVar(GetPlayerName(index) & ".ini", "PET", "activatedbefore", 1) Then
                        If GetVar(GetPlayerName(index) & ".ini", "PET", "petactivated", 0) Then
                                  Call ScriptSpawnNpc(npconmap1, playermap, playerx, playery, petnumber)
                                  Call PutVar(GetPlayerName(index) & ".ini", "PET", "petactivated", 1)
                                  Call PlayerMsg(index, "You summoned your pet", GREEN)
                                  Call SetPlayerMP(index, playermp)
                    End If
                        End If
Exit Sub

```

so like this? ( oh btw, read your answer after posting…sorry... ;D )

[Godlord]

```
If GetVar(GetPlayerName(index) & ".ini", "PET", "activatedbefore", 0) Then
```Should be:
```
If Int(GetVar(GetPlayerName(index) & ".ini", "PET", "activatedbefore")) = 0 Then
```
```
Call PutVar(GetPlayerName(index) & ".ini", "PET", "petactivated", 1)
```Should be:
```
Call PutVar(GetPlayerName(index) & ".ini", "PET", "petactivated", "1")
```or:
```
Call PutVar(GetPlayerName(index) & ".ini", "PET", "petactivated", CStr(1))
```
To give just a few examples.

Regards,
  Godlord.