Simple quest? SIMPLE???

[viesty]

Okay, this is my problem-
when i try to add this basic script:
```
Sub ScriptedNPC(index, Script)
Select Case Script
    Case 0
        If CheckInventoryForItem(index, 2) = true Then
            Call TakeItem(index, 2, 0)
            Call GiveItem(index, 3, 0)
            Call PlayerMsg(index, "Congrats quest complete.", 4)
        Else
            Call PlayerMsg(index, "You don't have item 2", 4)
        End If
End Select
End Sub
```
And I put npc on script 0, and attack it, it brings me a message- NPCz work.
What the hell is wrong?

It looks like this-

[Lanphrost]

You have two case 0
I'm assuming that because the first case 0 has call playermsg(index, "NPCz work", 15) that it's sending that message and ignoring the second case 0
Try replacing the old case 0

(If that works… that would make my first actual scripting advice... scary...)

[Saida]

I really need to learn sad script because I get what it means but that's about it.

[viesty]

Lanphrost, thanks, but doesn't work anyways :S
Now it doesn't show anything.

[Lanphrost]

Ah, well… :( I'm still an unprogrammer then X3

[Admiral Refuge]

Which version of the main.txt are you using?  Because that doesn't look like EE's main.txt

Anyway, you forgot to have "Case Else" in the Case statement (not sure if it it's needed or not), and you forgot to add the Exit Sub command.

Here's a screenshot of my main.txt, with that part:

[viesty]

I am using Fulou's main.txt

[Chakkra]

replace EVERYTHING in the scripted NPC section with this
```
'**************************************************************
' Executes whenever a scripted NPC does an action.
Sub ScriptedNPC(Index, Script)
'**************************************************************
Select Case Script

    Case 0
        If CheckInventoryForItem(index, 2) = true Then
            Call TakeItem(index, 2, 0)
            Call GiveItem(index, 3, 0)
            Call PlayerMsg(index, "Congrats quest complete.", 4)
        Else
            Call PlayerMsg(index, "You don't have item 2", 4)
        End If
Exit sub
Case Else
Call PlayerMsg(Index, "No NPC script found. Please contact an admin to solve this problem.", WHITE)
Exit Sub
End Select
End Sub
```
Works like a charm.

And if it doesn't work for you, don't blame me because you don't know how to follow simple instructions. It's not my fault if you don't know what i'm talking about.

[Squiddle]

Also, make sure you HAVE the sub "CheckforinventoryItem" put into your main, as I don't think it comes with the original?