Laggy Game Trade Fix

[Matt]

I don't know if many people have had this problem, but i know i have.

Whenever there is a laggy connection between the host and the player and two people are trading, if one of them hits decline, there's a bit of lag before the trade screen closes. If the person hits decline again, it makes the server get a RTE. My fix for this is to place```

frmMain.picTrade.Visible = False

```

right under

```

DeclineTrade

```

in client side

```

Private Sub imgDeclineTrade_Click()

' If debug mode, handle error then exit out

If Options.Debug = 1 Then On Error GoTo errorhandler

DeclineTrade

' Error handler

Exit Sub

errorhandler:

HandleError "imgDeclineTrade_Click", "frmMain", Err.Number, Err.Description, Err.Source, Err.HelpContext

Err.Clear

Exit Sub

End Sub

```

[Alerd]

Sorry for the questions but I know English poorly or under DeclineTrade I give

frmMain.picTrade.Visible = False

[Matt]

That's pretty much what the tutorial tells you to do.

[Alerd]

I know this because I asked the English … The problem was a yes or no answer ..?

[Valentine90]

The delay is a normal thing, this procedure may not be necessary.

[Matt]

> The delay is a normal thing, this procedure may not be necessary.

I understand the delay is normal, but if a player hits decline more than once, the server crashes.

[Valentine90]

That's why I created tutorials to fix this problem

http://www.touchofdeathforums.com/community/index.php?/topic/129445-bug-fix-fixing-serious-errors-in-trade/

Still, I appreciate you trying to help your shape

[Richy420Rich]

Or in the server HandleDeclineTrade, try adding check to make sure the .InTrade for player and target is greater than 0.

Place the close trade calls after the end if.

No need to try fixing server errors from the client.

```

Sub HandleDeclineTrade(ByVal index As Long, ByRef Data() As Byte, ByVal StartAddr As Long, ByVal ExtraVar As Long)

Dim i As Long

Dim tradeTarget As Long

tradeTarget = TempPlayer(index).target

If tradeTarget > 0 And TempPlayer(index).InTrade > 0 And TempPlayer(tradeTarget).InTrade > 0 Then

For i = 1 To MAX_INV

TempPlayer(index).TradeOffer(i).Num = 0

TempPlayer(index).TradeOffer(i).value = 0

TempPlayer(tradeTarget).TradeOffer(i).Num = 0

TempPlayer(tradeTarget).TradeOffer(i).value = 0

Next

PlayerMsg index, "You declined the trade.", brightred

PlayerMsg tradeTarget, GetPlayerName(index) & " has declined the trade.", brightred

End If

TempPlayer(index).InTrade = 0

TempPlayer(tradeTarget).InTrade = 0

TempPlayer(index).AcceptTrade = False

TempPlayer(tradeTarget).AcceptTrade = False

SendCloseTrade index

SendCloseTrade tradeTarget

End Sub

```

Could try something like this.