I need help scripting (didnt know where to put this)

[Nobody]

i made a script and it doesn't work i am new at scripting and i already read all of yellow moles scripting tutorial and i wanted to try this (: any ideas on how i could improve so that it works?' Executes when a player logs into the game.
Sub JoinGame(Index)

                  Case 1
If GetPlayerAccess(Index) = 0 Then
Call GlobalMsg(GetPlayerName(Index) & " has joined " & GameName & "!", GREY)
                  Case 2 
                  If GetPlayerAccess(Index) = 1 Then
Call GlobalMsg("Mod " & GetPlayerName(Index) & " has joined " & GameName & "!", PINK)
                  Case 3
                  If GetPlayerAccess(Index) = 2 Then
Call GlobalMsg("Mapper " & GetPlayerName(Index) & " has joined " & GameName & "!", BLUE)
                Case 4
                  If GetPlayerAccess(Index) = 3 Then
Call GlobalMsg(" Developer" & GetPlayerName(Index) & " has joined " & GameName & "!", RED)
                  Case 5
                  If GetPlayerAccess(Index) = 4 Then
Call GlobalMsg("Admin " & GetPlayerName(Index) & " has joined " & GameName & "!",CYAN)
                Case 6
                  If GetPlayerAccess(Index) = 5 Then
Call GlobalMsg("Owner " & GetPlayerName(Index) & " has joined " & GameName & "!", MAGENTA)

End If

Call PlayerMsg(Index, "Welcome to " & GameName & "!", WHITE)

If LenB(MOTD) <> 0 Then
Call PlayerMsg(Index, "MOTD: " & MOTD, BRIGHTCYAN)
End If

Call SendWhosOnline(Index)
End Sub

[Ruins of Hell]

```
Sub JoinGame(Index)
Select Case GetPlayerAccess(index)
  If GetPlayerAccess(Index) = 0 Then
      Call GlobalMsg(GetPlayerName(Index) & " has joined " & GameName & "!", GREY)
                  Case 1
      Call GlobalMsg("Mod " & GetPlayerName(Index) & " has joined " & GameName & "!", PINK)
                  Case 2
      Call GlobalMsg("Mapper " & GetPlayerName(Index) & " has joined " & GameName & "!", BLUE)
                Case 3
      Call GlobalMsg(" Developer" & GetPlayerName(Index) & " has joined " & GameName & "!", RED)
                  Case 4
      Call GlobalMsg("Admin " & GetPlayerName(Index) & " has joined " & GameName & "!",CYAN)
                Case 5
      Call GlobalMsg("Owner " & GetPlayerName(Index) & " has joined " & GameName & "!", MAGENTA)
End Select

  Call PlayerMsg(Index, "Welcome to " & GameName & "!", WHITE)

  If LenB(MOTD) <> 0 Then
      Call PlayerMsg(Index, "MOTD: " & MOTD, BRIGHTCYAN)
  End If

  Call SendWhosOnline(Index)
End Sub

```
You had several unclosed Ifs, and then you were using cases for an if?

[Nobody]

oh i am new at this could you break it down a little XD
like i should not be using cases their ?
how would i close the ifs?

[Ruins of Hell]

End If

Select Case picks the case that matches what you select.

If you wanted to have multiple options with an If, you would use:
```
If GetPlayerAccess(index) = 0 Then
...code...
ElseIf GetPlayerAccess(index) = 1 Then
...code...
ElseIf GetPlayerAccess(index) = 2 Then
...code...
ElseIf GetPlayerAccess(index) = 3 Then
...code...
ElseIf GetPlayerAccess(index) = 4 Then
...code...
ElseIf GetPlayerAccess(index) = 5 Then
...code...
End If

```

[Nobody]

Thank you  :cheesy: this will help me a lot  XD
by the way how do you put the code in
Code: (vb)
for future references

[Nobody]

And it works  :azn: :cry: :azn:

[Ruins of Hell]

['code]
…code...
[/'code]

Remove the '.

Warning - while you were typing a new reply has been posted. You may wish to review your post.

@Nobody:

> And it works  :azn: :cry: :azn:

Of course it works!

[Nobody]

Thanks a lot man  :cheesy:

[Ruins of Hell]

No problem, it's nice to see new scripters around :D.

[Lam3r]

Hey real quick if you could answer this Soul (sorry i didn't want to start a new thread just for this)

What exactly is a Case used for? Why not just use If/Else If? Or a While loop or something?

[Nobody]

The final Edit of this script can be found on http://www.touchofdeathforums.com/smf/index.php/topic,54981.msg582041/topicseen.html#new  (: enjoy

[Ruins of Hell]

@Lam3r:

> Hey real quick if you could answer this Soul (sorry i didn't want to start a new thread just for this)
>
> What exactly is a Case used for? Why not just use If/Else If? Or a While loop or something?

Because, using Cases is **a lot** faster than going through all those conditional checks.

[balliztik1]

Well, it depends on the situation, really. Cases are actually slower, but they are more precise. That is, they don't have to check every condition, but they are slower at finding the right condition. For this reason, it's not a good idea to use a Case for anything less than 3 or 4 choices, as it will probably not be necessary. However, because Cases are order independent, no matter what value you throw at them, there won't be a delay. For instance:

```
If value = 1 Then
'Blah
ElseIf value = 2 Then
'Blah
ElseIf value = 3 Then
'Blah
ElseIf value = 4 Then
'Blah
End If
```
Say the value you use is 4\. This means it has to test the first condition, fail it, then the second, and then the third before finally finding the correct choice. On the other hand:

```
Select Case value
    Case 1
        'Blah
    Case 2
        'Blah
    Case 3
        'Blah
    Case 4
        'Blah
End Select
```
This code will jump straight to 4\. Because it's not testing a conditional, but rather "jumping" to the correct value, it skips unnecessary checks. However, suppose the value was 1\. Instead of immediately fulfilling the condition, it must find the variable's value, then make the aforementioned jump. In short, the longer the string of ElseIfs, the less efficient they become, and the shorter a Case switch is, the less efficient it becomes.

Yeah, a bit of random info for the topic, but hey, I've got time. Knowledge is power! ;D