Subscript of of range, please help.

[achap89]

Im trying to get a part of a picture.
```
Dim itemnum
Dim itempic
Dim MaxFrames
MaxFrames = (DDSD_Item(itempic).lWidth / 2) / 32
itemnum = GetPlayerEquipment(MyIndex, weapon)
If itemnum > 0 Then
itempic = Item(itemnum).Pic
Picture1.Picture = LoadPicture("data files\graphics\items\" & MaxFrames & ".bmp")
Else
Exit Sub
End If

```
It highlights
```
MaxFrames = (DDSD_Item(itempic).lWidth / 2) / 32
```
What am i doing wrong?

[Scott]

```
Dim itemnum
Dim itempic
Dim MaxFrames

```
You need to declare what type of variables these will be.

ex
```
Dim MaxFrames as Long

```
and Subscript out of range means your trying to access an element of an array that does not exist, make sure itempic is within the proper range of the DDSD_Item array.

[achap89]

still gives me the error

[Scott]

If it's still subscript out of range than read the last part of my post, if not what error is it now?

[achap89]

```
Dim itemnum
Dim itempic
Dim MaxFrames As Byte
Dim DDSD_Item As DDSURFACEDESC2
MaxFrames = (DDSD_Item(itempic).lWidth / 2) / 32
itemnum = GetPlayerEquipment(MyIndex, weapon)
If itemnum > 0 Then
itempic = Item(itemnum).Pic
Picture1.Picture = LoadPicture("data files\graphics\items\" & MaxFrames & ".bmp")
Else
Exit Sub
End If

```give me "compile error expexted array"
and highlights the DDSD_Item

[Scott]

Why do you have this here now?
```
Dim DDSD_Item As DDSURFACEDESC2
```
This should already be declared in the modDirectDraw7, not to mention your trying to call it as an array when it's not which was causing your error.

[achap89]

Because it still gives me a subscript out of range without it.

[Scott]

Than fix the subscript error, its simple your trying to access a part of an array which does not exist, so the number in the itempic variable is 1 of 2 things.

1.Lower than 1
2.Above your max item images

[achap89]

nope neither…  I just changed it to >= 0 and my max item images is not part seeing as its only item number 3 of 255

[Scott]

You don't even have a type declared for itempic in the last snipit you posted, a subscript out of range error means your trying to access a part of an array that does not exist, so make sure your not feeding any numbers above or below its range into that array.

Example.
If an array is set to be 1-10and you try to call 11 or 0 you get a subscript out of range.

```
Dim TestArray(1 To 10) as Long

TestArray(11) = 4

```This would give you a subscript out of range because it's not using a number between 1 and 10 which is the min/max elements of this array.

[achap89]

Ok well can you help me because I am new to coding XD  I do have a type now it is a long.

Private Sub Picture1_Click()

Dim itemnum As Long
Dim itempic As Long
Dim MaxFrames
itempic = Item(itemnum).Pic
MaxFrames = (DDSD_Item(itempic).lWidth / 2) / 32
itemnum = GetPlayerEquipment(MyIndex, weapon)
If itemnum > 0 Then
Picture1.Picture = LoadPicture("data files\graphics\items\" & MaxFrames & ".bmp")
Else
Exit Sub
End If

End Sub

That was the whole code.

also its in the frmmain

sorry for the double post.

[Please do not double post.]

[Scott]

1\. It seems MaxFrames lost its type again.

2.What are you trying to do here?

3.Use code tags please makes it easier to read

4.Format your code its annoying to read like that.

```
Dim itemnum As Long
Dim itempic As Long
Dim MaxFrames As Byte

    MaxFrames = (DDSD_Item(itempic).lWidth / 2) / 32
    itemnum = GetPlayerEquipment(MyIndex, weapon)

    If itemnum > 0 Then
        itempic = Item(itemnum).Pic
        Picture1.Picture = LoadPicture("data files\graphics\items\" & MaxFrames & ".bmp")
    Else
        Exit Sub
    End If

```This should fix the subscript error, you where trying to use itemnum before you assigned it.

[achap89]

Trying to show equiped items in a special menu.

[Scott]

Look how its done in Sub BltEquipment() you need to blt it.

[achap89]

can u help me XD

I can get it to show an image but i cant get it to go to the second part of the image and not show it all.

in the highlighted portion I get
(DDSD_Item(itempic).lWidth / 2) / 32  is the error

[Scott]

Doing it the way your trying to is going about it wrong, copy how its done with Equipment, look at Sub BltEquipment() for how it's done in that case.

[achap89]

I have looked at it… Once again I am a new coder I have no idea what any of it is about.  So can you please help me.