[Bug Fix] Fixing a serious error in Party

[Valentine90]

**Sorry my english**

The Party system contains several serious errors:

1) You can accept invitation to anyone who has left the game;

2) The name of the new leader of the party is wrong;

3) When the party ends some members continues with a party that no longer exists;

4) Other errors.

**Open Server**

**1 -** In **modHandleData**, look for:

```
Sub HandleAcceptParty
```

**2 -** Below add:

```
If Not IsConnected(TempPlayer(index).partyInvite) Or Not IsPlaying(TempPlayer(index).partyInvite) Then

TempPlayer(index).partyInvite = 0

Exit Sub

End If
```

**3 -** In **modGameLogic**, look for:

```
Public Sub Party_PlayerLeave
```

**4 -** Replace:

```
PartyMsg partyNum, GetPlayerName(i) & " is now the party leader.", BrightBlue
```

**5 -** By:

```
PartyMsg partyNum, GetPlayerName(Party(partynum).Leader) & " is now the party leader.", BrightBlue
```

**6 -** Beneath of:

```
' remove from array

For i = 1 To MAX_PARTY_MEMBERS

If Party(partynum).Member(i) = index Then

Party(partynum).Member(i) = 0

Exit For

End If

Next
```

**7 -** Add:

```
TempPlayer(index).inParty = 0

TempPlayer(index).partyInvite = 0
```

**8 -** Beneath of:

```
For i = 1 To MAX_PARTY_MEMBERS

If Party(partyNum).Member(i) = index Then

Party(partyNum).Member(i) = 0

Exit For

End If

Next
```

**9 -** Add:

```
TempPlayer(index).inParty = 0

TempPlayer(index).partyInvite = 0
```

**10 -** Look for:

```
Public Sub Party_InviteAccept
```

**11 -** Replace:

```
Dim partynum As Long, i As Long
```

**12 -** By:

```
Dim partynum As Long, i As Long, x As Long
```

**13 -** Replace:

```
SendPartyVitals partyNum, targetPlayer
```

**14 -** By:

```
For x = 1 To MAX_PARTY_MEMBERS

If Party(partynum).Member(x) > 0 Then

SendPartyVitals partynum, Party(partynum).Member(x)

End If

Next
```

**15 -** Beneath of:

```
PlayerMsg targetPlayer, "Party is full.", BrightRed
```

**16 -** Add:

```
TempPlayer(targetPlayer).partyInvite = 0
```

**17 -** Look for:

```
Public Sub Party_ShareExp
```

**18 -** Beneath of:

```
Dim expShare As Long, leftOver As Long, i As Long, tmpIndex As Long
```

**19 -** Add:

```
If Party(partynum).MemberCount <= 0 Then Exit Sub
```

**Credits:**

Valentine

[JohnPony]

Oh nice bug fix man, i overlooked this completely when i was making some edits to the party framework in a project.

[Alerd]

I have 2```
SendPartyVitals partyNum, targetPlayer
```

```

' send update to all - including new player

SendPartyUpdate partyNum

SendPartyVitals partyNum, targetPlayer

```

or

```

' create the party

Party(partyNum).MemberCount = 2

Party(partyNum).Leader = Index

Party(partyNum).Member(1) = Index

Party(partyNum).Member(2) = targetPlayer

SendPartyUpdate partyNum

SendPartyVitals partyNum, Index

SendPartyVitals partyNum, targetPlayer

```

hich I replace?

[Valentine90]

The First

```
' send update to all - including new player

SendPartyUpdate partyNum

SendPartyVitals partyNum, targetPlayer
```

[Whackeddie99]

Shouldn't

```

If Party(partynum).MemberCount <= 0 Then Exit Sub

```

Be

```

If Party(partynum).MemberCount <= 1 Then Exit Sub

```

Because you can't make a party without two people, this would prevent it if for some reason only one player was in a party.

[Valentine90]

I put this, for if the player has left the party and for some reason the server trying to divide the exp using **Party_ShareExp**, it will exit the sub.

[Alerd]

that is, I have to replace the 0 to 1? and more generally

```
If Party (partynum). MemberCount <= 0 Then Exit Sub
```

Be

```

If Party (partynum). MemberCount <= 1 Then Exit Sub
```

?

[Ganjika]

Are these bugs in _dragon eclipse_ and/or eclipse reborn?

[Wortel Angels]

Take a look and youll know it…

[Valentine90]

Are bugs on the version of eclipse origins v2 officer, who has the same bugs provavalmente on derivative versions as you mentioned, since these versions are just a bunch of poorly made and bugs systems, systems upon systems.