Timed Event script. [Solved]

[cheatking]

Can someone tell me why this isn't working please?
```
Sub TimedEvent(Hours, Minutes, Seconds)
    Dim MAPWEATHER
    Dim Weather
    If Minutes = 30 Then
        If Seconds = 0 Then
            Weather = Rand(1, 3)
            MAPWEATHER = 1
            Do While MAPWEATHER < 15
                Call SetWeather(MAPWEATHER, Weather, 10)
                MAPWEATHER + 1
            Loop
            Call PlayerMsg(Index, "Testing Weather", WHITE)
        End If
    End If
End Sub
```

[RetroX]

I am not keen on setting vars to 0.
1 minute has 60 seconds, but… are they 0 - 59 or 1 - 60
You can try figuring out if 0 or 1 is the starting second but the easiest is to simply use a bit higer value.

If Seconds = 5 Then

Second thing you could test:
below: Call SetWeather(MAPWEATHER, Weather, 10)
you can add: Call PlayerMsg(Index, "DEBUG: Weather should have changed to " & Weather  &  " on map: " & MAPWEATHER, WHITE)

this way you should read 15 time that the weather changed on the maps (and to what value).

[cheatking]

Ok this is the script now.
```
Sub TimedEvent(Hours, Minutes, Seconds)
Dim MAPWEATHER
Dim Weather
Dim Index
If Minutes = 30 Then
If Seconds = 5 Then
Weather = Rand(1, 3)
MAPWEATHER = 1
Do While MAPWEATHER < 15
Call SetWeather(MAPWEATHER, Weather, 10)
MAPWEATHER = MAPWEATHER + 1
Loop
Call PlayerMsg(Index, "DEBUG: Weather should have changed on map: " & MAPWEATHER, WHITE)
End If
End If
End Sub
```
I get a type missmatch now.

[RetroX]

In the serverfile, frmServer holds a routine called Private Sub Timer1_Timer() that triggers the clock and the "TimedEvent".

Try This:
In the serverwindow
tab: ControlPanel

Set time to
Houres: -doesnt matter-
Minutes: 29
Seconds: 0

Gamespeed: 1

Scripting ON

When the time reaches x:30:05 it should trigger the script.

[cheatking]

Yea thats what I do to test it. It doesn't work.

[RetroX]

To see if the sub is working at all your could try the following:

right below:
    Sub TimedEvent(Hours, Minutes, Seconds)

add the following code:
    Dim Bugtracker
    Bugtracker = "H:" & Hours & " M:" & Minutes & " S:" & Seconds
    Call PlayerMsg(Index, "DEBUG: " & bugtracker , WHITE)

It should give you actual time based on the variables you need for your 'If … Then' statements.

[cheatking]

I decided to hard code it. It works now :)

[RetroX]

Thats another sollution  :cheesy:

still wondering what the problem could be in the script :huh:

[cheatking]

Hmm… Now a different problem... It triggers a dosen times.

[RetroX]

Lol!
It probably has multiple 'ticks' within the second. You can add an "allow" var. Like this:

Dim AllowRun
AllowRun = 1          '1: Yes,  0: No

If Seconds = 5 Then
        If AllowRun = 1 Then
              … execute code ....
              AllowRun = 0        'so the next time within this second is may not run
        End If
End If
If Seconds = 6 Then
        AllowRun = 1                'set the trigger to yes for the next run
end If

[cheatking]

```
    Dim Wth
    Dim Done
    If Minutes = 30 Then
        If Seconds = 30 Then
            Wth = Int(Rnd * 3)
            If Done = 0 Then
                Call SendData("weather" & SEP_CHAR & Wth & END_CHAR)
                Done = 1
            End If
            If Seconds = 31 Then
                Done = 0
            End If
        End If
    End If
```Am i cursed? Why don't it work?

[RetroX]

It should. The only thing i can think of is the declaration of the vars. Mixup in Strings and Integers. To test you could try this:

If Val(Minutes) = 30 Then

or

If Minutes = "30" Then

_same for  houres and seconds_

[cheatking]

It works better in the server lol.