HPBar problem.

[zenmen]

Hey! How to fix this issue? I want my HPBar load from the bottom to the top, not like now, from top to bottom ..

Scree: 

How to fix it?

[Joost]

Please post your HandlePlayerHP sub from the clientside.

[zenmen]

```
Private Sub HandlePlayerHp(ByVal Index As Long, ByRef Data() As Byte, ByVal StartAddr As Long, ByVal ExtraVar As Long)
Dim Buffer As clsBuffer

    ' If debug mode, handle error then exit out
    If Options.Debug = 1 Then On Error GoTo errorhandler

    Set Buffer = New clsBuffer
    Buffer.WriteBytes Data()
    Player(MyIndex).MaxVital(Vitals.HP) = Buffer.ReadLong
    Call SetPlayerVital(MyIndex, Vitals.HP, Buffer.ReadLong)

    If GetPlayerMaxVital(MyIndex, Vitals.HP) > 0 Then
        'frmMain.lblHP.Caption = Int(GetPlayerVital(MyIndex, Vitals.HP) / GetPlayerMaxVital(MyIndex, Vitals.HP) * 100) & "%"
        frmMain.lblHP.Caption = GetPlayerVital(MyIndex, Vitals.HP) & "/" & GetPlayerMaxVital(MyIndex, Vitals.HP)
        ' hp bar
        frmMain.ImgHPBar.height = ((GetPlayerVital(MyIndex, Vitals.HP) / HPBar_Height) / (GetPlayerMaxVital(MyIndex, Vitals.HP) / HPBar_Height)) * HPBar_Height
    End If

    ' Error handler
    Exit Sub
errorhandler:
    HandleError "HandlePlayerHP", "modHandleData", Err.Number, Err.Description, Err.Source, Err.HelpContext
    Err.Clear
    Exit Sub
End Sub
```

[Joost]

This is a bit of a guess, but try
```
    If GetPlayerMaxVital(MyIndex, Vitals.HP) > 0 Then
        'frmMain.lblHP.Caption = Int(GetPlayerVital(MyIndex, Vitals.HP) / GetPlayerMaxVital(MyIndex, Vitals.HP) * 100) & "%"
        frmMain.lblHP.Caption = GetPlayerVital(MyIndex, Vitals.HP) & "/" & GetPlayerMaxVital(MyIndex, Vitals.HP)
        ' hp bar
        frmMain.ImgHPBar.top = ((GetPlayerVital(MyIndex, Vitals.HP) /  frmMain.ImgHPBar.top) / (GetPlayerMaxVital(MyIndex, Vitals.HP) /  frmMain.ImgHPBar.top)) *  frmMain.ImgHPBar.top
    End If

    ' Error handler
    Exit Sub
errorhandler:
    HandleError "HandlePlayerHP", "modHandleData", Err.Number, Err.Description, Err.Source, Err.HelpContext
    Err.Clear
    Exit Sub
```It's definatly the .Top attribute you need to adjust instead of the .Height variable that's used now. Im just not sure if the math works out like this.

[zenmen]

Hah, now its funny ; D Please chceck the screenshot:


[Joost]

```
    If GetPlayerMaxVital(MyIndex, Vitals.HP) > 0 Then
        'frmMain.lblHP.Caption = Int(GetPlayerVital(MyIndex, Vitals.HP) / GetPlayerMaxVital(MyIndex, Vitals.HP) * 100) & "%"
        frmMain.lblHP.Caption = GetPlayerVital(MyIndex, Vitals.HP) & "/" & GetPlayerMaxVital(MyIndex, Vitals.HP)
        ' hp bar
        frmMain.ImgHPBar.top = ((GetPlayerVital(MyIndex, Vitals.HP) /  frmMain.ImgHPBar.top) / (GetPlayerMaxVital(MyIndex, Vitals.HP) /  frmMain.ImgHPBar.top)) *  frmMain.ImgHPBar.top + *insert ur thing*
    End If

    ' Error handler
    Exit Sub
errorhandler:
    HandleError "HandlePlayerHP", "modHandleData", Err.Number, Err.Description, Err.Source, Err.HelpContext
    Err.Clear
    Exit Sub
```Can you try again with this code, and fill in *insert ur thing* with the .Top of your frmMain.ImgHPBar.

[zenmen]

I dont understand:

> and fill in *insert ur thing* with the .Top of your frmMain.ImgHPBar.

How it must look? You mean "frmMain.ImgHPBar.top + HPBar_Height" ?

But if i do that with this code its nothing change, still the same what is on the screen.

[Joost]

no, go into your frmMain, click the hp frame and check what value "Top" is, add that to the code

[zenmen]

Now i dont see my bitmap of ImgHPBar.

> If GetPlayerMaxVital(MyIndex, Vitals.HP) > 0 Then
>         'frmMain.lblHP.Caption = Int(GetPlayerVital(MyIndex, Vitals.HP) / GetPlayerMaxVital(MyIndex, Vitals.HP) * 100) & "%"
>         frmMain.lblHP.Caption = GetPlayerVital(MyIndex, Vitals.HP) & "/" & GetPlayerMaxVital(MyIndex, Vitals.HP)
>         ' hp bar
>         frmMain.ImgHPBar.top = ((GetPlayerVital(MyIndex, Vitals.HP) / frmMain.ImgHPBar.top) / (GetPlayerMaxVital(MyIndex, Vitals.HP) / frmMain.ImgHPBar.top)) * frmMain.ImgHPBar.top + 589
>     End If
>
>     ' Error handler
>     Exit Sub
> errorhandler:
>     HandleError "HandlePlayerHP", "modHandleData", Err.Number, Err.Description, Err.Source, Err.HelpContext
>     Err.Clear
>     Exit Sub
>     End Sub

[Joost]

I think both Top + height need to be adjusted properly to set it up properly and to be honest I am way too stoned to do smart mathz. The top needs to move down so the image moves down, while the height needs to shrink with an equal amount to make sure the image doesnt just go down but stays on the same spot.

[zenmen]

That is, You will try to help me (read - do it for me ^ ^)? Unfortunately I do not know much about programming, so or I find a ready-made solution, or the GUI to be thrown away : P

Anyway, now I thank you for the above help! :)

[Joost]

In ModGlobal add

```
Public HPTop As Long
Public HPHeight As Long
Public HPOffset As Long
```
In```
Private Sub Form_Load()
```on frmMain add
```
HpTop = ImgHPBar.Top
HpHeight = ImpHpBar.Height
HpOffSet = HpHeight - HpTop
```
Replace
```
        frmMain.ImgHPBar.top = ((GetPlayerVital(MyIndex, Vitals.HP) / frmMain.ImgHPBar.top) / (GetPlayerMaxVital(MyIndex, Vitals.HP) / frmMain.ImgHPBar.top)) * frmMain.ImgHPBar.top + 589
```with
```

Percentage = (GetPlayerVital(MyIndex, Vitals.HP / GetPlayerMaxVital(MyIndex, Vitals.HP)
ImgHpBar.Top = HpTop + (HpOffSet * Percentage)
ImgHpBar.Height = HpHeight - (HPOffset * Percentage)

```
Add Dim Percentage As Long at the top of that sub.

[Joost]

This was my proof of concept to make sure my math was ok. Make a new project, add a Picture1 and a Hscroll1 and you can test the math. So if there are any mistakes in the above code, it is probably something small and stupid.

```
Public A As Long
Public B As Long
Public C As Long
Public Percentage As Long

Private Sub Change()

    Picture1.Top = A - (C * Percentage / 100)
    Picture1.Height = B + (C * Percentage / 100)

End Sub

Private Sub Form_Load()
    A = Picture1.Top
    B = Picture1.Height
    C = (A - B)
End Sub

Private Sub HScroll1_Change()
Percentage = HScroll1.Value
Call Change

End Sub

```

[zenmen]

Thank you! But.. (yeah thats only me..) i have got some error (ofcoure i add all Publics etc in modGlobals and frmMain):

Link: 

And there is some bugs:

> HpTop = ImgHPBar.Top
> HpHeight = Im**p**HpBar.Height
> HpOffSet = HpHeight - HpTop

and parentheses but I do not know how they should be:

> Percentage = (GetPlayerVital(MyIndex, Vitals.HP / GetPlayerMaxVital(MyIndex, Vitals.HP)**))**
> ImgHpBar.Top = HpTop + (HpOffSet * Percentage)
> ImgHpBar.Height = HpHeight - (HPOffset * Percentage)

or:

> Percentage = (GetPlayerVital(MyIndex, Vitals.HP**)** / GetPlayerMaxVital(MyIndex, Vitals.HP)**)**
> ImgHpBar.Top = HpTop + (HpOffSet * Percentage)
> ImgHpBar.Height = HpHeight - (HPOffset * Percentage)

I really thank you for your help!  :embarrassed:

[Joost]

```
Percentage = (GetPlayerVital(MyIndex, Vitals.HP / GetPlayerMaxVital(MyIndex, Vitals.HP)
frmMain.ImgHpBar.Top = HpTop + (HpOffSet * Percentage)
frmMain.ImgHpBar.Height = HpHeight - (HPOffset * Percentage)
```
That should fix that problem.

```
HpHeight = ImpHpBar.Height
```That was just a typo, but I assume you fixed that already

```
Percentage = GetPlayerVital(MyIndex, Vitals.HP) / GetPlayerMaxVital(MyIndex, Vitals.HP)
ImgHpBar.Top = HpTop + (HpOffSet * Percentage)
ImgHpBar.Height = HpHeight - (HPOffset * Percentage)
```That one is correct.

[zenmen]

Haha now its crazy! : D Just look:


:confused:

[Joost]

can you pm/post your source code so I can fix it properly? In my demo project the stuff seems to work so Im not really sure what's wrong.

[zenmen]

Joost, what about this code?

```
    With Health_Bar

            If Player.Stats.Total_Health <> 0 Then HP = (Player.Stats.Current_Health / Player.Stats.Total_Health) * .Frame_Size.Bottom

Vertex_List(0) = Create_TLVertex(.X + .Frame_Size.Left, .Y + .Frame_Size.Top, 0, 1,  D3DColorRGBA(255, 255, 255, 255), 0, 0, 0)

Vertex_List(1) = Create_TLVertex(.X + .Frame_Size.Left, .Y + HR, 0, 1, D3DColorRGBA(255, 255, 255, 255), 0, 0, 1)

    End With
```
Its something change?

[Joost]

That is the code for drawing the health bar under players, and is not really related. It's just something with my math is still fucked up, I will look into it tonight.

[Ruins of Hell]

Try this:

* * *

Find:
```
Public HPBar_Width As Long

```
and under add:
```
Public HPBar_Height As Long

```
Next find:
```
' store the bar widths for calculations

```
and under add:
```
    HPBar_Height = frmMain.imgHPBar.height

```
Then use this code for the calculations in HandlePlayerHP:
```
frmMain.imgHPBar.height = GetPlayerVital(MyIndex, Vitals.HP) / GetPlayerMaxVital(MyIndex, Vitals.HP) * HPBar_Height

```

[zenmen]

Yes, I exactly do that at the begginging which gave me that effect:

>!