NPC's freeze when a player dies

[igloo9]

In my game, when a player gets killed by a monster or something, this is what happens:

All of the NPC's freeze.  Then, the server gives me this error:

TYPE: Subscript out of range
LINE: 10
COLUMN: 0
CODE:

I hit OK, and it pops back up.  I hit OK a second time, and it pops back up.  After the third time, the message goes away.  However, the server stays online, and then the NPC's start moving again.

The above process repeats any time someone dies.  How do I fix this?  It's gonna make it easy for the players if I'm not at home, and someone dies, because then everyone can fight frozen NPC's that don't fight back.

Help. D:

[devilbleep]

Did you add a script?

[igloo9]

I don't think.  I mean, here's what happened:

I used Eclipse Stable for my game.  Everything worked fine.  Then, I got a new client with some changes in the source (To display player's HP as well as hide names under fringe.)

Since I couldn't use the new client with my game, I just had to transfer all of the server folders over, such as accounts, etc.  I added the same scripts and everything.

Basically, I transferred my game from an older Eclipse Stable to a new one.

And now this happens.

[kanechart]

your prob having scripting issues. Does this happen on the new stable with no old stuff accepted the exe I made ya? if not then its in ur scripts and ur on your own there :(

[igloo9]

Kind of.  It goes like this…

Your client.exe that you gave me, with the source edits.
New Eclipse Stable file/server/scripts/etc.
Old folders and stuff such as NPC's, Items, Exp, etc. from my game.
Custom scripts from the old game transferred over into the new scripts folder.

[Marsh]

Perhaps the person that edited your client messed it up.

[balliztik1]

It's in the scripts. The client would crash if it was a client issue. You're using Stable, and have scripting errors set to 1\. For a simple fix, turn off error messages. For a more permanent fix, let me see your OnNPCDeath sub.

[igloo9]

@Ballie:

> It's in the scripts. The client would crash if it was a client issue. You're using Stable, and have scripting errors set to 1\. For a simple fix, turn off error messages. For a more permanent fix, let me see your OnNPCDeath sub.

Well, the server doesn't really "crash."  It just displays an error message which freezes the NPCs.  When I "OK" out of it, the NPCs are normal again.

If I turn off error messages, wouldn't that still freeze them but without giving me the error?

Here's my OnNPCDeath sub-

```
Sub OnNPCDeath(Index, Map, NPC, MapNPC)
Call BattleMsg(Index, "You killed a " & GetNPCName(NPC) & ".", BRIGHTRED, LEFT)
End Sub
```
Edit: Wait, wouldn't it be playerdeath and not NPCdeath?  Because it happens when you die, not the NPC.

[balliztik1]

Oh…Well, I can pinpoint a problem, but I can't read. xD  Bring me the other sub!

And I know the server doesn't crash. The server pauses, but the client doesn't. The server waits for input on the error message. If there is no error message, there is no pause.

[igloo9]

@Ballie:

> Oh…Well, I can pinpoint a problem, but I can't read. xD  Bring me the other sub!
>
> And I know the server doesn't crash. The server pauses, but the client doesn't. The server waits for input on the error message. If there is no error message, there is no pause.

What other sub do you need?

And just in case it doesn't work, how do I cancel or disable error messages?

[Marsh]

@Igloo9:

> @Ballie:
>
> > Oh…Well, I can pinpoint a problem, but I can't read. xD  Bring me the other sub!
> >
> > And I know the server doesn't crash. The server pauses, but the client doesn't. The server waits for input on the error message. If there is no error message, there is no pause.
>
> What other sub do you need?
>
> And just in case it doesn't work, how do I cancel or disable error messages?

Havent used stable but i believe in your data.ini changed scriptingerrors = 1 to = 0

[balliztik1]

The OnDeath sub, I guess. Whichever it is that dictates NPCs killing a player.

[igloo9]

Cool, that worked Marsh.  Thanks :)  And Ballie yeah here is the sub:  (Just in case)

```
Sub OnDeath(Index)
If GetMapBootMap(Index) > 0 Then
Call PlayerWarp(Index, GetMapBootMap(Index), GetMapBootX(Index), GetMapBootY(Index))
Else
Map = CInt(GetVar("Classes\Class" & GetPlayerClass(Index) & ".ini", "CLASS", "Map"))
X = CInt(GetVar("Classes\Class" & GetPlayerClass(Index) & ".ini", "CLASS", "x"))
Y = CInt(GetVar("Classes\Class" & GetPlayerClass(Index) & ".ini", "CLASS", "y"))

Call PlayerWarp(Index, Map, X, Y)
End If

Call SetPlayerHP(Target, GetPlayerMaxHP(Target))
Call SetPlayerMP(Target, GetPlayerMaxMP(Target))
Call SetPlayerSP(Target, GetPlayerMaxSP(Target))
Call SendPlayerData(Target)
End Sub
```

[balliztik1]

```
Call SetPlayerHP(Target, GetPlayerMaxHP(Target))
  Call SetPlayerMP(Target, GetPlayerMaxMP(Target))
  Call SetPlayerSP(Target, GetPlayerMaxSP(Target))
  Call SendPlayerData(Target)
```
This is the issue. Target is not defined. Plus, whenever OnDeath is called from the source, it already restores health. You might consider eliminating this altogether, or just switching to indices. Regardless, SendPlayerData is not needed. The SetPlayerHP/MP/SP commands auto-update themselves.

```
Call SetPlayerHP(index, GetPlayerMaxHP(index))
  Call SetPlayerMP(index, GetPlayerMaxMP(index))
  Call SetPlayerSP(index, GetPlayerMaxSP(index))
```

[igloo9]

Thanks so much :) So basically are you saying to replace it with the code you put below?

[balliztik1]

Yes.

[igloo9]

Thanks :)