[EO] Alatar's Quest System v1.2

[mkldoido]

**Error:** "Method or data member not found"

**in ".PlayerQuest", of function:**

```
Public Function QuestInProgress(ByVal index As Long, ByVal QuestNum As Long) As Boolean
    QuestInProgress = False
    If QuestNum < 1 Or QuestNum > MAX_QUESTS Then Exit Function

    If Player(index)[.PlayerQuest(QuestNum).Status = QUEST_STARTED Then 'Status=1 means started
        QuestInProgress = True
    End If
    End Function
```
Anyone helpme???
I declared all Types, and yet add modules…

[Antisora]

@jcsnider:

> He added the modules to the src folder but never added them to the project, I fixed it through teamviewer. Issue Resolved :D

Thanks for that, still trying to find a way to properly thank you

[erkro1]

@mkldoido:

> **Error:** "Method or data member not found"
>
> **in ".PlayerQuest", of function:**
>
> ```
> Public Function QuestInProgress(ByVal index As Long, ByVal QuestNum As Long) As Boolean
>     QuestInProgress = False
>     If QuestNum < 1 Or QuestNum > MAX_QUESTS Then Exit Function
>
>     If Player(index)[.PlayerQuest(QuestNum).Status = QUEST_STARTED Then 'Status=1 means started
>         QuestInProgress = True
>     End If
>     End Function
> ```
> Anyone helpme???
> I declared all Types, and yet add modules…

Replace it with this :
```
Public Function QuestInProgress(ByVal index As Long, ByVal QuestNum As Long) As Boolean
    QuestInProgress = False
    If QuestNum < 1 Or QuestNum > MAX_QUESTS Then Exit Function

    If Player(index).PlayerQuest(QuestNum).Status = QUEST_STARTED Then 'Status=1 means started
        QuestInProgress = True
    End If
    End Function
```

* * *

Also, I've made a fix for taking/giving items on the start of a quest :
In **modHandleData** replace **HandlePlayerHandleQuest** with this :
```
Sub HandlePlayerHandleQuest(ByVal index As Long, ByRef Data() As Byte, ByVal StartAddr As Long, ByVal ExtraVar As Long)
Dim Buffer As clsBuffer
Dim QuestNum As Long, Order As Long

Set Buffer = New clsBuffer
Buffer.WriteBytes Data()
QuestNum = Buffer.ReadLong
Order = Buffer.ReadLong '1 = accept, 2 = cancel
If Order = 1 Then
Player(index).PlayerQuest(QuestNum).Status = QUEST_STARTED '1
Player(index).PlayerQuest(QuestNum).ActualTask = 1
Player(index).PlayerQuest(QuestNum).CurrentCount = 0
PlayerMsg index, "New quest accepted: " & Trim$(Quest(QuestNum).Name) & "!", BrightGreen
    If Quest(QuestNum).StartItem > 0 And Quest(QuestNum).StartItemValue > 0 Then
    GiveInvItem index, Quest(QuestNum).StartItem, Quest(QuestNum).StartItemValue
    End If
    If HasItem(index, Quest(QuestNum).StartRemoveItem) And Quest(QuestNum).StartRemoveItem > 0 And Quest(QuestNum).StartRemoveItemValue > 0 Then
    TakeInvItem index, Quest(QuestNum).StartRemoveItem, Quest(QuestNum).StartRemoveItemValue
    End If
ElseIf Order = 2 Then
Player(index).PlayerQuest(QuestNum).Status = QUEST_NOT_STARTED '2
End If
SavePlayer index
SendPlayerData index
SendPlayerQuest index, QuestNum
Set Buffer = Nothing
End Sub
```

[Guest]

just tried it out, seems its backwards on when it gives takes, but it at least is better than it was.  i made a few quests to test it out.  instead of giving on start and taking on end it will either

a.  give on start, not take on end. 
or
b. take on start, give on end.

this was tried with combinations of multiple tasks, single tasks, talk to, get from, give to, take on start, give on start. 

and lastly it will give items in stack form, so its not good to give more than 1 item, you drop stack on ground, its instantly just 1 item again. 

again tho still better than before.

[erkro1]

@sotvotkong:

> just tried it out, seems its backwards on when it gives takes, but it at least is better than it was.  i made a few quests to test it out.  instead of giving on start and taking on end it will either
>
> a.  give on start, not take on end. 
> or
> b. take on start, give on end.
>
> this was tried with combinations of multiple tasks, single tasks, talk to, get from, give to, take on start, give on start. 
>
> and lastly it will give items in stack form, so its not good to give more than 1 item, you drop stack on ground, its instantly just 1 item again. 
>
> again tho still better than before.

I know it isn't perfect, I'm still improving it. ;)
Also, this fixes only take/give item **at start**

[Guest]

@Erwin:

> I know it isn't perfect, I'm still improving it. ;)
> Also, this fixes only take/give item **at start**

yea i was thinking that. during my testing it seems as tho that was the case.  as for the on starts, if used seperatly they work as intended, if used in same quest on multi task, it works backwards lol.

[askumi]

im getting some runtime error..

"Run-time error '9':
Subscript out of range"

it happens when i hit end to open up my questlog

[erkro1]

@askumi:

> im getting some runtime error..
>
> "Run-time error '9':
> Subscript out of range"
>
> it happens when i hit end to open up my questlog

Run it in the IDE and click Debug ehen error comes up, and tell us what line he's selecting.

[Weegee]

This is good still has some bugs though.

[Dennys]

~~Im getting a RTE 9 when i try to open quest log. The error sends me to the line In clsBuffer Public Sub WriteBytes
Im using EO 2.0~~

Nvm i fixed it, i was just missing some lines from the tutorial, Sorry. Great Quest System.  :P

[shadowdeath]

Works Great.
Simple Question though,
How about adding a button to view the quest log?
Anyone give me a hand?
I'd appreciate it. :)

[erkro1]

@shadowdeath:

> Works Great.
> Simple Question though,
> How about adding a button to view the quest log?
> Anyone give me a hand?
> I'd appreciate it. :)

I'll make a tutorial for that tomorrow and ill post it in this thread.
I also gonna add a 'Train resource' fix ;)

[shadowdeath]

K.
Thanks dude.

[erkro1]

@shadowdeath:

> K.
> Thanks dude.

Your welcome, just improving the system and sharing it with the community. ;)

[shadowdeath]

So, when you going to post how to do it?

[erkro1]

@shadowdeath:

> So, when you going to post how to do it?

I was kinda busy today, I'll post it tomorrow, sorry.

[shadowdeath]

Hey, quick question.
I have a different folder which has a project that already has a Quest Button.
If I copy and paste that data over mine, (Just the VB Project Files, etc.) not the actual maps, etc.
Will that erase the quests I already have made?

[erkro1]

**Quest Log Button Tutorial**

**Client Side**

Alright, first **make a button somewere in picMain**, make sure Visible = True.

Double click on the button and **add this in the button_click sub** :
```
UpdateQuestLog
            If picQuestLog.Visible Then
                ShowQuestLogPage 1
            Else
                picQuestLog.Visible = True
                picInventory.Visible = False
                picCharacter.Visible = False
                picSpells.Visible = False
                picOptions.Visible = False
                picParty.Visible = False
          End If
```
And there we have our Quest Log Button ;)

* * *

**Fix for 'Train Resource' quest type**

**Server Side**

In **modPlayer** in **Sub CheckResource** under :
```
' carry on
GiveInvItem index, Resource(Resource_index).ItemReward(FinalReward), 1
SendAnimation GetPlayerMap(index), Resource(Resource_index).Animation, rX, rY
```
Add :
```
Call CheckTasks(index, QUEST_TYPE_GOTRAIN, Resource_index)
```
And now the Train Resource quest type works. ;)

[shadowdeath]

Thanks dude. :D

[terabin]

I finished the tutorial.
but when I attack it nothing happens …

[erkro1]

@terabin:

> I finished the tutorial.
> but when I attack it nothing happens …

Add some health and stats to the NPC.

[terabin]

But when I start the mission to kill an NPC, so I kill the NPC the following error occurs:


Run Time Error "9"
Subscript out of range

help plis =/

[shadowdeath]

You probably added the code in wrong.
Download his base version and then try.

[terabin]

no have errors o.o

[shadowdeath]

What?